Enhance JWT verification in AuthMiddlewares and update test assertions for unauthorized access#1542
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances JWT verification in the authentication middlewares by adding user existence and suspension checks, and updates test assertions to reflect the new unauthorized access behavior.
Changes:
- Added database validation to verify that users exist and are not suspended during JWT authentication
- Reordered API key validation logic to check for null before accessing suspended property
- Updated test expectations to reflect 401 Unauthorized responses instead of 403/404 when accessing endpoints after user/company deletion or suspension
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/src/authorization/auth.middleware.ts | Enhanced JWT verification with user existence and suspension checks; reformatted with tabs for consistency |
| backend/src/authorization/auth-with-api.middleware.ts | Added user existence and suspension checks for JWT authentication; fixed null check ordering in API key validation |
| backend/test/ava-tests/saas-tests/user-e2e.test.ts | Updated test assertion to expect 401 status when accessing user endpoint after deletion |
| backend/test/ava-tests/saas-tests/company-info-e2e.test.ts | Updated test assertions to expect 401 status for deleted company and suspended user scenarios |
| backend/test/ava-tests/non-saas-tests/non-saas-user-e2e.test.ts | Updated test assertion to expect 401 status when accessing user endpoint after deletion |
| backend/test/ava-tests/non-saas-tests/non-saas-company-info-e2e.test.ts | Updated test assertion to expect 401 status when accessing company endpoint after deletion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.